Update unix contributing docs#29379
Merged
jaredpar merged 2 commits intodotnet:masterfrom Aug 20, 2018
Merged
Conversation
Updated the docs based on my experiences getting the emit tests running on Linux.
Member
Author
|
CC @dotnet/roslyn-compiler for review |
Member
Author
|
retest ubuntu_16_debug_prtest please |
jcouv
reviewed
Aug 20, 2018
| @@ -1,14 +1,87 @@ | |||
| # Getting the Code | |||
| # Building, Debugging and Testing on Windows | |||
Member
There was a problem hiding this comment.
Windows [](start = 37, length = 7)
Linux #Closed
Member
Author
There was a problem hiding this comment.
Hmm ... oops 😦 #Closed
Member
Author
There was a problem hiding this comment.
Using Unix instead of Linux as that's the more genercal name for Mac / Linux testing. The doc has a lot of Linux specific info but it's also generally applicable to Mac as well. #Closed
jcouv
reviewed
Aug 20, 2018
| - cd into `ubuntu/18.04` instead of `ubuntu/16.04` | ||
|
|
||
| ### Source Link | ||
| Many of the repositories that need to be built use source link and it crashes on Ubuntu 18.04 due to depndency changes. |
Member
There was a problem hiding this comment.
depndency [](start = 101, length = 9)
typo: dependency
jcouv
reviewed
Aug 20, 2018
| <EnableSourceLink>false</EnableSourceLink> | ||
| <DeterministicSourcePaths>false</DeterministicSourcePaths> | ||
| ``` | ||
| ### Prereqs |
Member
There was a problem hiding this comment.
Prereqs [](start = 4, length = 7)
nit: spell out "Prerequisites"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the docs based on my experiences getting the emit tests running
on Linux.