Initial documentation for the TestAccessor Pattern#28967
Merged
sharwell merged 1 commit intodotnet:mainfrom May 26, 2022
Merged
Initial documentation for the TestAccessor Pattern#28967sharwell merged 1 commit intodotnet:mainfrom
sharwell merged 1 commit intodotnet:mainfrom
Conversation
This was referenced Aug 1, 2018
Member
|
@sharwell What is the status for this? |
Youssef1313
suggested changes
Jan 21, 2022
Youssef1313
reviewed
Jan 21, 2022
Youssef1313
reviewed
Jan 21, 2022
Contributor
Author
I was just following the pattern set by other files in the folder. |
CyrusNajmabadi
approved these changes
May 26, 2022
Contributor
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
LGTM. Can you add a section on the right pattern for static data, as well as preferred way to expose mutable and non-mutable data?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.