Update naming styles to ensure .editorconfig is the code style "source of truth"#27942
Merged
sharwell merged 1 commit intodotnet:masterfrom Jun 19, 2019
Merged
Conversation
18f5044 to
ed3c52c
Compare
Contributor
Author
|
This went to a design review 18 June 2018. The conclusion from that meeting was the following:
|
ed3c52c to
d43103d
Compare
…e of truth" Prior to this change, user settings could interact with .editorconfig in unknown ways to produce deviations in code style across a team which could not be controlled by simply updating .editorconfig. This change ensures that .editorconfig, when used, becomes the code style "source of truth" for affected documents.
d43103d to
936791d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, user settings could interact with .editorconfig in unknown ways to produce deviations in code style across a team which could not be controlled by simply updating .editorconfig. This change ensures that .editorconfig, when used, becomes the code style "source of truth" for affected documents.
Previous design
Prior to this change, the current editor options are made available to code deserializing values from .editorconfig. This was only used in one place in the current code: naming styles defined in Tools → Options were appended to options (if any) that were defined in .editorconfig.
New design