Skip to content

Specify vs.file.ngenApplication#27526

Merged
tmat merged 2 commits intodotnet:masterfrom
tmat:ngen
Jun 7, 2018
Merged

Specify vs.file.ngenApplication#27526
tmat merged 2 commits intodotnet:masterfrom
tmat:ngen

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented Jun 6, 2018

Without vs.file.ngenApplication VS uses configuration of devenv process for NGEN, which might have different binding redirects than VBCSCompiler.exe.config.

@tmat tmat requested a review from a team as a code owner June 6, 2018 18:02
@Huy-Nguyen-MSFT
Copy link
Copy Markdown

Huy-Nguyen-MSFT commented Jun 6, 2018

LGTM 👍

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Jun 6, 2018

test windows_debug_spanish_unit32_prtest please

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Jun 6, 2018 •
edited
Loading

windows_debug_spanish_unit32_prtest reports IO errors

15:35:03 
Build step 'Execute Windows batch command' marked build as failure
15:35:03 FATAL: Remote call on JNLP4-connect connection from 40.112.160.176/40.112.160.176:10176 failed. The channel is closing down or has closed down

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Jun 6, 2018

test windows_debug_spanish_unit32_prtest please

@tmat tmat merged commit cc1d006 into dotnet:master Jun 7, 2018
@tmat tmat deleted the ngen branch June 7, 2018 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmat @Huy-Nguyen-MSFT @jaredpar @jasonmalinowski