Revert #25047 - [SQLite] Bump and use byte[] variants added to blob_open for performance#27484
Merged
OmarTawfik merged 1 commit intodotnet:masterfrom Jun 6, 2018
OmarTawfik:dev/otawfik/revert-sqllite-binary
Merged
Revert #25047 - [SQLite] Bump and use byte[] variants added to blob_open for performance#27484OmarTawfik merged 1 commit intodotnet:masterfrom OmarTawfik:dev/otawfik/revert-sqllite-binary
OmarTawfik merged 1 commit intodotnet:masterfrom
OmarTawfik:dev/otawfik/revert-sqllite-binary
Conversation
tannergooding
approved these changes
Jun 5, 2018
Member
|
FYI. @jinujoseph and @jasonmalinowski as well. |
jinujoseph
approved these changes
Jun 5, 2018
Member
|
@OmarTawfik (or @jinujoseph) could we get a bug logged tracking getting this re-enabled. If 1.1.5 works, we can just move to that. Otherwise, we need to ensure the appropriate binding redirects are added to VS. In either case, we should also ensure we are consuming the shared copy, rather than inserting our own. |
heejaechang
reviewed
Jun 5, 2018
| <SystemXmlXmlSerializerVersion>4.3.0</SystemXmlXmlSerializerVersion> | ||
| <SystemXmlXPathXDocumentVersion>4.3.0</SystemXmlXPathXDocumentVersion> | ||
| <SQLitePCLRawbundle_greenVersion>1.1.11</SQLitePCLRawbundle_greenVersion> | ||
| <SQLitePCLRawbundle_greenVersion>1.1.2</SQLitePCLRawbundle_greenVersion> |
Contributor
There was a problem hiding this comment.
we only need to revert this. not whole thing...?
Member
There was a problem hiding this comment.
The other changes require this change
Contributor
There was a problem hiding this comment.
are we reverting whole thing to be safe?
Contributor
There was a problem hiding this comment.
The ReadBlob(byte[]) APIs were added in 1.1.10, so it would not build otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #25047 as it is causing NGen issues in official builds.
We need to consolidate different versions of that binary that ship into VS.
cc @tannergooding can you please review?