TryParse API for language version no longer an extension method#27461
TryParse API for language version no longer an extension method#27461jcouv merged 4 commits intodotnet:masterfrom
Conversation
|
@dotnet-bot test windows_debug_vs-integration_prtest |
|
@dotnet/roslyn-compiler One-liner for review. Thanks |
|
From discussion with @cston, I'll ping compat council to see if we can just take the break (not make it an extension method). |
| @@ -1,5 +1,6 @@ | |||
| // Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | |||
|
|
|||
| using System.ComponentModel; | |||
734fb8d to
96fa301
Compare
|
@dotnet/roslyn-ide @jinujoseph for a tiny review. I had to update a few lines of IDE code/tests to adjust to this change to a compiler API. Thanks |
1 similar comment
|
@dotnet/roslyn-ide @jinujoseph for a tiny review. I had to update a few lines of IDE code/tests to adjust to this change to a compiler API. Thanks |
|
@jcouv PR descripition no longer reflects the content? I see comments about EditorBrowsable.Never but don't see that in the code. I presume this has gotten whatever breaking change signoffs you need? |
|
@jasonmalinowski Thanks. Updated the description. @jinujoseph for ask-mode approval for 15.8. Thanks |
|
Approved to merge from IDE side for 15.8.Preview4 |
|
Thanks |
Customer scenario
If you reference the compiler nuget package, an extension on the
stringtype becomes available. That has been reported as being annoying (it adds an unexpected completion).I'm making this API a regular (non-extension) method to remedy this.
Bugs this fixes
Fixes #26132
Workarounds, if any
Risk
Performance impact
Low. Just make the the API non-extension.