Offer generate variable fixer when inside a lock statement in C##27402
Merged
jinujoseph merged 2 commits intodotnet:masterfrom Jun 5, 2018
Merged
Offer generate variable fixer when inside a lock statement in C##27402jinujoseph merged 2 commits intodotnet:masterfrom
jinujoseph merged 2 commits intodotnet:masterfrom
Conversation
CyrusNajmabadi
approved these changes
Jun 4, 2018
mavasani
approved these changes
Jun 4, 2018
Contributor
|
@jinujoseph for approval |
Contributor
|
@davidwengier could you resolve the conflict |
de0081a to
27aba12
Compare
Member
Author
|
Resolved conflicts. If the tests pass again this should hopefully be good :) |
Contributor
|
test windows_debug_spanish_unit32_prtest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show generate variable fix inside lock
Customer scenario
When typing a new identifier inside a lock statement none of the Generate Variable fixers are offered as suggestions.
Bugs this fixes
Fixes #26406
Workarounds, if any
None
Risk
Low, the fix is one more item in a switch statement, and Visual Basic already had that option. I've added tests for C# and VB to prevent regression.
Performance impact
Low, no extra allocations etc.
Is this a regression from a previous update?
I don't know
Root cause analysis
There is a large switch statement that has a whitelist of places where the generate variable refactoring is offered, and it was missing from there. There is a reasonable chance there are other things listed.
How was the bug found?
I was just browsing Help Wanted issues, guessing the original requester found it in the course of using VS.
Test documentation updated?
N/A?