Allow passing in a workspace for a ContainedLanguage#27316
Merged
jinujoseph merged 1 commit intodotnet:masterfrom Jun 1, 2018
srivatsn:razorsupport
Merged
Allow passing in a workspace for a ContainedLanguage#27316jinujoseph merged 1 commit intodotnet:masterfrom srivatsn:razorsupport
jinujoseph merged 1 commit intodotnet:masterfrom
srivatsn:razorsupport
Conversation
jinujoseph
approved these changes
Jun 1, 2018
heejaechang
approved these changes
Jun 1, 2018
jasonmalinowski
approved these changes
Jun 1, 2018
Contributor
|
Approved to merge for 15.8.Preview3 |
Contributor
|
test windows_debug_spanish_unit32_prtest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer scenario
When a Razor file is opened in a Live Share guest session, we currently don't populate the roslyn workspace and hence don't get language services. This change makes it so that we can pass in the remote workspace to make it possible to get language services in a cshtml file.
Bugs this fixes
(either VSO or GitHub links)
Workarounds, if any
None
Risk
Low
Performance impact
Low - doesn't change code for mainline scenarios.
Is this a regression from a previous update?
No
How was the bug found?
Part of Live Share work.