Make VisualBasicAdditionalFormattingRuleLanguageService a singleton.#27238
Merged
sharwell merged 1 commit intodotnet:masterfrom Jun 4, 2018
Conversation
sharwell
approved these changes
Jun 4, 2018
Contributor
|
@jinujoseph for approval. I verified that all types involved have no mutable state. |
Contributor
|
Approved to merge for 15.8.Preview3 |
Contributor
Author
|
@sharwell Would you mind sharing, how you did the verification. Curious |
Contributor
|
@AdamSpeight2008 visual review of the types via source.roslyn.io 😄 |
Contributor
Author
|
@sharwell Though you had some clever code to validate them. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make VisualBasicAdditionalFormattingRuleLanguageService a singleton.