Skip to content

Upgrade Microsoft.CodeAnalysis.Analyzers version to 2.6.1#27191

Merged
jmarolf merged 2 commits intodotnet:masterfrom
jmarolf:update-analyzer-versions-for-nuget-packages
Jun 5, 2018
Merged

Upgrade Microsoft.CodeAnalysis.Analyzers version to 2.6.1#27191
jmarolf merged 2 commits intodotnet:masterfrom
jmarolf:update-analyzer-versions-for-nuget-packages

Conversation

@jmarolf
Copy link
Copy Markdown
Contributor

@jmarolf jmarolf commented May 26, 2018

Fixes #24899

@jmarolf jmarolf requested review from agocke and mavasani May 26, 2018 16:15
@jmarolf jmarolf requested a review from a team as a code owner May 26, 2018 16:15
@sharwell
Copy link
Copy Markdown
Contributor

💭 Interested to see if everything downstream works after this but seems fine.

@mavasani
Copy link
Copy Markdown
Contributor

We need 2.6.1 (not yet produced) to include Dustin’s MSBuild analyzer. I will produce and publish this package on Tuesday.

@jmarolf
Copy link
Copy Markdown
Contributor Author

jmarolf commented May 30, 2018

@mavasani what is the status of 2.6.1?

@jmarolf jmarolf closed this May 30, 2018
@jmarolf jmarolf reopened this May 30, 2018
@mavasani
Copy link
Copy Markdown
Contributor

@mavasani what is the status of 2.6.1?

They are currently being tested. I have added you to the email thread.

@etbyrd
Copy link
Copy Markdown
Contributor

etbyrd commented May 31, 2018

@dotnet-bot test windows_debug_spanish_unit32_prtest

Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcouv jcouv added this to the 15.8 milestone Jun 5, 2018
@jcouv jcouv changed the title Upgrade Microsoft.CodeAnalysis.Analyzers version to 2.6.0 Upgrade Microsoft.CodeAnalysis.Analyzers version to 2.6.1 Jun 5, 2018
@jmarolf
Copy link
Copy Markdown
Contributor Author

jmarolf commented Jun 5, 2018

retest windows_debug_spanish_unit32_prtest please

@jmarolf jmarolf merged commit 0f4cd9b into dotnet:master Jun 5, 2018
@jmarolf jmarolf deleted the update-analyzer-versions-for-nuget-packages branch January 27, 2020 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants