Conversation
|
I prefer |
|
@sharwell I prefer |
| Friend Const Main As String = "vb.Main" | ||
| Friend Const Async As String = "vb.Async" | ||
| Friend Const Iterator As String = "vb.Iterator" | ||
| Friend Const Await As String = "vb.Await" |
There was a problem hiding this comment.
Side Note: The colour of Await and Yield are incorrect, should be black in this context.
| Friend Shared Iterator As String = "vb.Iterator" | ||
| Friend Shared Await As String = "vb.Await" | ||
| Friend Shared Yield As String = "vb.Yield" | ||
| Friend Const Assign As String = "vb.Assign" |
There was a problem hiding this comment.
can we use shared-readonly instead?
There was a problem hiding this comment.
➡️ As I mentioned above, this is currently the subject of an open design discussion which we'll make a decision on and report back. To avoid unnecessary back and forth it didn't make sense to request a change until the design review reaches a conclusion.
|
This went to a design meeting yesterday. Since the impacted code did not fall into the public API surface (even though IVTs are potentially impacted), we did not reach a final conclusion regarding an expected pattern future developers are supposed to follow. We therefore reviewed this as a refactoring operation without clear guidance on the 'one right way' to proceed. Since the old code unexpectedly defined the fields as mutable, we felt that a change to |
|
Approved to merge for 15.8.Preview3 |
|
@sharwell What does IVTs mean? as it a new acronym to me. |
|
IVT => Internal Visible True |
Fix for Issue #27189