Skip to content

Add a test that shows a bug is fixed.#27162

Merged
gafter merged 1 commit intodotnet:masterfrom
gafter:master-21077
May 30, 2018
Merged

Add a test that shows a bug is fixed.#27162
gafter merged 1 commit intodotnet:masterfrom
gafter:master-21077

Conversation

@gafter
Copy link
Copy Markdown
Member

@gafter gafter commented May 25, 2018

Fixes #21077

@dotnet/roslyn-compiler Need one review of this compiler test-only addition, please.

@gafter gafter added Area-Compilers 4 - In Review A fix for the issue is submitted for review. Test Test failures in roslyn-CI labels May 25, 2018
@gafter gafter added this to the 15.8 milestone May 25, 2018
@gafter gafter self-assigned this May 25, 2018
@gafter gafter requested a review from a team May 25, 2018 19:05
@jcouv
Copy link
Copy Markdown
Member

jcouv commented May 25, 2018

Are you sure the issue link is correct? #21007 is not an issue, but a merged PR.

@gafter
Copy link
Copy Markdown
Member Author

gafter commented May 26, 2018

Should be #21077

@gafter
Copy link
Copy Markdown
Member Author

gafter commented May 26, 2018

@dotnet/roslyn-compiler Need one review of this compiler test-only addition, please.

@gafter
Copy link
Copy Markdown
Member Author

gafter commented May 30, 2018

@jcouv Does this test look OK to you?

Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@jcouv
Copy link
Copy Markdown
Member

jcouv commented May 30, 2018

@gafter I think this can be merged.

@jcouv jcouv self-assigned this May 30, 2018
@gafter gafter merged commit 2887b8b into dotnet:master May 30, 2018
@gafter gafter removed the 4 - In Review A fix for the issue is submitted for review. label May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Test Test failures in roslyn-CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants