Add missing dependency of target _BeforeVBCSCoreCompile#26970
Merged
tmat merged 1 commit intodotnet:dev15.7.xfrom May 22, 2018
Merged
Add missing dependency of target _BeforeVBCSCoreCompile#26970tmat merged 1 commit intodotnet:dev15.7.xfrom
tmat merged 1 commit intodotnet:dev15.7.xfrom
Conversation
Member
Author
|
@nguerrera @jaredpar @dotnet/roslyn-compiler PTAL |
nguerrera
approved these changes
May 18, 2018
rainersigwald
approved these changes
May 18, 2018
jaredpar
approved these changes
May 18, 2018
Member
Author
|
test windows_release_vs-integration_prtest please |
Member
Author
|
Seems like this was approved by shiproom. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer scenario
Build of XAML project targeting .NET 3.5 may fail.
Bugs this fixes
VSO 616987
Workarounds, if any
Customer can set
EmbedInteropTypesto false on references.Risk
Small.
Performance impact
None.
Is this a regression from a previous update?
Yes.
Root cause analysis
The project generated for XAML build invokes CoreCompile directly without executing Compile target. Due to a missing dependency the target
ShimReferencePathsWhenCommonTargetsDoesNotUnderstandReferenceAssembliesmay get executed after_BeforeVBCSCoreCompile, which depends on the results of the former.How was the bug found?
Customer reported.
Test documentation updated?