Skip to content

Move Spanish image to RS4#26861

Merged
jaredpar merged 1 commit intodotnet:masterfrom
jaredpar:fix-image
May 15, 2018
Merged

Move Spanish image to RS4#26861
jaredpar merged 1 commit intodotnet:masterfrom
jaredpar:fix-image

Conversation

@jaredpar
Copy link
Copy Markdown
Member

https://github.com/dotnet/core-eng/issues/3420

Ask Mode template not completed

Customer scenario

What does the customer do to get into this situation, and why do we think this
is common enough to address for this release. (Granted, sometimes this will be
obvious "Open project, VS crashes" but in general, I need to understand how
common a scenario is)

Bugs this fixes

(either VSO or GitHub links)

Workarounds, if any

Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW

Risk

This is generally a measure our how central the affected code is to adjacent
scenarios and thus how likely your fix is to destabilize a broader area of code

Performance impact

(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")

Is this a regression from a previous update?

Root cause analysis

How did we miss it? What tests are we adding to guard against it in the future?

How was the bug found?

(E.g. customer reported it vs. ad hoc testing)

Test documentation updated?

If this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.

@jaredpar jaredpar requested a review from a team as a code owner May 15, 2018 15:23
@jaredpar
Copy link
Copy Markdown
Member Author

This can't be really tested as it's changing a groovy file. Merging and will monitor the job creation after merge.

@jaredpar jaredpar merged commit b58d01c into dotnet:master May 15, 2018
@jaredpar jaredpar deleted the fix-image branch May 15, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant