Remove value that is not used in fix all.#26822
Merged
mavasani merged 4 commits intodotnet:masterfrom May 15, 2018
Merged
Conversation
Contributor
Author
|
Tagging @dotnet/roslyn-ide @mavasani @heejaechang @jcouv @sharwell |
sharwell
approved these changes
May 12, 2018
Contributor
There was a problem hiding this comment.
👍 To commit c4ab17d. @CyrusNajmabadi Were you planning on adding to this or can we call it complete there?
Contributor
Author
This PR is complete as is. I have a couple of followup changes, but they will be in new PRs as they change actual behavior. thanks! |
Contributor
Author
|
Tagging @jcouv Very simple PR, thanks :) |
Contributor
Author
|
@sharwell can this go in? |
mavasani
approved these changes
May 14, 2018
Contributor
Author
|
@mavasani do you want to merge in? Thanks! |
Contributor
|
Tagging @jinujoseph for approval |
Contributor
|
Approved to merge to 15.8.Preview3 |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm generally trying to clean up the last remaining use of specialized fix-all (which is in simplify type names). I expect to make several refactorings in this area. But i will try my best to keep commits clean and independent when possible.