made "foreach to for" to only support rank1 array.#26750
Merged
heejaechang merged 1 commit intodotnet:masterfrom May 15, 2018
Merged
made "foreach to for" to only support rank1 array.#26750heejaechang merged 1 commit intodotnet:masterfrom
heejaechang merged 1 commit intodotnet:masterfrom
Conversation
otherwise, it will pick up IList but Array implementation only support Rank==1 on runtime even if there is no compile time error.
CyrusNajmabadi
approved these changes
May 10, 2018
| { | ||
| void Method() | ||
| { | ||
| foreach [||] (int a in new int[,] { {1, 2} }) |
Contributor
There was a problem hiding this comment.
note: this is somewhat dangerous. If we ever changed the span to be only teh 'foreach', then this test would continue failing, but not for the right reason. Code action tests try to pick a span that should always be safe even in the presence of future refinements to the applicability span.
Contributor
Author
|
retest this please |
Contributor
Author
|
@jinujoseph can I get approval for 15.8? |
Contributor
|
Approved to merge for 15.8.Preview3 |
Contributor
Author
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
otherwise, it will pick up IList but Array implementation only support Rank==1 on runtime even if there is no compile time error.
fixes - #26748