Exclude Microsoft.Composition as something we build a dependency map for #26725
Merged
jasonmalinowski merged 2 commits intodotnet:masterfrom May 8, 2018
Merged
Exclude Microsoft.Composition as something we build a dependency map for #26725jasonmalinowski merged 2 commits intodotnet:masterfrom
jasonmalinowski merged 2 commits intodotnet:masterfrom
Conversation
This creates ironically the reverse effect you might imagine: CompilerExtension contains this package now, which would cause it to be added to the dependency map; this then causes the package to be excluded from the insertion package, where it is supposed to be. Since CompilerExtension and VS are (in some sense) separate targets, presence in the former shouldn't impact the other.
Member
Author
|
Merging to unblock insertions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates ironically the reverse effect you might imagine: CompilerExtension contains this package now, which would cause it to be added to the dependency map; this then causes the package to be excluded from the insertion package, where it is supposed to be. Since CompilerExtension and VS are (in some sense) separate targets, presence in the former shouldn't impact the other.