Fix the message for Make Field Readonly#26718
Merged
jinujoseph merged 2 commits intodotnet:masterfrom May 9, 2018
Merged
Conversation
Contributor
Author
|
@jinujoseph This is based on dev15.7.x branch so we can take it wherever needed. |
jinujoseph
approved these changes
May 8, 2018
| } | ||
| catch (NotSupportedException) | ||
| { | ||
| return; |
Contributor
There was a problem hiding this comment.
when does this happen?
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
A comment might be wise here.
| public static DiagnosticDescriptor CreateSimpleDescriptor(string id) | ||
| { | ||
| return new DiagnosticDescriptor(id, title: "", messageFormat: "", category: "", | ||
| return new DiagnosticDescriptor(id, title: "", messageFormat: id, category: "", |
Contributor
There was a problem hiding this comment.
is this appropriate? seems... strange...
Contributor
Author
There was a problem hiding this comment.
💭 It's easier than further work to specialize the behavior for a test-only analyzer.
mavasani
approved these changes
May 8, 2018
jasonmalinowski
approved these changes
May 8, 2018
| } | ||
| catch (NotSupportedException) | ||
| { | ||
| return; |
Member
There was a problem hiding this comment.
A comment might be wise here.
…wing an exception
Contributor
|
Approved to merge for 15.8.Preview2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26219
Customer scenario
A customer upgrades to version 15.7. IDE0044 warnings start appearing, but no description is given for the warning so it's not clear to users what the problem is.
Bugs this fixes
Fixes #26219
Workarounds, if any
None, but also none needed. In order to understand a workaround, users would need to understand what IDE0044 is. Once a user understands what IDE0044 is without a description, no workaround is needed.
Risk
Very low. The fix is production code is clear and concise.
Performance impact
None.
Is this a regression from a previous update?
IDE0044 is new for the 15.7 release, so "errors appear without a description" could be considered a regression. On the other hand, IDE0044 never shipped in a previous release with a description.
Root cause analysis
Several items contributed to this issue:
How was the bug found?
Customer reported
Test documentation updated?
No, but a regression test is added to ensure the situation does not reappear for existing or new diagnostics.