Skip to content

Bump version to 2.8.1#26550

Merged
genlu merged 1 commit intodotnet:dev15.7.xfrom
genlu:bumpVersion
May 4, 2018
Merged

Bump version to 2.8.1#26550
genlu merged 1 commit intodotnet:dev15.7.xfrom
genlu:bumpVersion

Conversation

@genlu
Copy link
Copy Markdown
Member

@genlu genlu commented May 1, 2018

FYI @dotnet/roslyn-infrastructure. @jaredpar We are publish 15.7 p6 bits to nuget.org as 2.8.0. So after the publication, we will need to bump the version to 2.8.1 if we are gonna make more changes and do another insertion to d15.7.

@genlu genlu requested a review from a team as a code owner May 1, 2018 23:31
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't bump assembly version on minor releases. File version only.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will fix that.

@genlu
Copy link
Copy Markdown
Member Author

genlu commented May 2, 2018

@jaredpar Could you please make sure we merge this with any change to 15.7.x branch?

@jaredpar
Copy link
Copy Markdown
Member

jaredpar commented May 2, 2018

Could you please make sure we merge this with any change to 15.7.x branch?

I'm not sure what's being asked here. If we want this to merge with 15.7 then we should check into dev15.7.x.

@genlu
Copy link
Copy Markdown
Member Author

genlu commented May 2, 2018

I just didn't want to merge this unless there's actual change going into d15.7 RTW (or subsequent servicing releases), which probably doesn't really matter.

So this should go into 15.7.x instead?

@jasonmalinowski
Copy link
Copy Markdown
Member

@genlu We should preemptively merge this now, so that way when we do take the next change if/when that happens we don't forget. That's our usual process more or less. This should target dev15.7.x directly and not -vs-deps though.

@genlu genlu changed the base branch from dev15.7.x-vs-deps to dev15.7.x May 4, 2018 18:56
@genlu genlu merged commit dfa3eaa into dotnet:dev15.7.x May 4, 2018
@genlu genlu deleted the bumpVersion branch May 4, 2018 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants