Raise events when connecting or disconnecting from a workspace for semantic changed#26512
Conversation
|
test windows_debug_spanish_unit32_prtest please |
|
What's the end user impact of this change? In other words, how is this observable? Thanks! |
|
On F#, we currently have a bug of semantic highlighting taking 3-8 seconds when you load a project; part of the reason is that the text buffer wasn't registered until after it tried produce tags from the semantic changed events. With the PR, a semantic change event kicks off when the a text buffer gets registered. This PR doesn't fix the F# issue entirely, only part of it. C# does actually share a similar issue, its just not as noticeable due to semantic highlighting working before design time builds. This is not the case for F# as we have to wait for a designtime build. |
|
Cool, thanks for the explanation! |
|
I can't merge this in myself. Can someone else do it? |
Connecting/disconnecting from a workspace was not kicking off semantic changed event. Talking with @jasonmalinowski and @Pilchie on Friday, it seems like it was an oversight and should be fixed.