Avoid adding duplicate metadata references to AbstractProject reference list#26438
Merged
brettfo merged 1 commit intodotnet:dev15.7.xfrom Apr 28, 2018
Merged
Avoid adding duplicate metadata references to AbstractProject reference list#26438brettfo merged 1 commit intodotnet:dev15.7.xfrom
brettfo merged 1 commit intodotnet:dev15.7.xfrom
Conversation
Member
Author
|
@jasonmalinowski Please review. |
Pilchie
approved these changes
Apr 27, 2018
Member
Author
|
test windows_release_vs-integration_prtest please |
Member
Author
|
test windows_release_vs-integration_prtest please |
| { | ||
| lock (_gate) | ||
| { | ||
| if (_metadataReferences.Contains(r => StringComparer.OrdinalIgnoreCase.Equals(r.FilePath, reference.FilePath))) |
Member
There was a problem hiding this comment.
Hmm, I forget our conversation again: the classic project systems definitely try to consolidate references so I think this is safe. Did we double check what CPS does? I know they had some consolidation logic but I forget where that landed...?
Member
There was a problem hiding this comment.
CPS does that here. I wonder if this is a bug in DTBB in classic csproj.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer scenario
VS crashes due to a duplicate metadata reference added to the list of references the AbstractProject maintains. The root cause is unknown. This change prevents the crash and reports non-Fatal Watson at the point when the duplicate reference is being added, so that we can diagnose why it's happening.
Bugs this fixes
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/599686
Workarounds, if any
None.
Risk
Small.
Performance impact
Small.
Is this a regression from a previous update?
Root cause analysis
Unknown.
How was the bug found?
Watson report.
Test documentation updated?