Skip to content

Use 2.8-beta3 toolset compiler#26164

Merged
jcouv merged 3 commits intodotnet:masterfrom
jcouv:csharp-73
Apr 18, 2018
Merged

Use 2.8-beta3 toolset compiler#26164
jcouv merged 3 commits intodotnet:masterfrom
jcouv:csharp-73

Conversation

@jcouv
Copy link
Copy Markdown
Member

@jcouv jcouv commented Apr 15, 2018 •
edited
Loading

Fixes #25816

@jcouv jcouv added this to the 15.8 milestone Apr 15, 2018
@jcouv jcouv self-assigned this Apr 15, 2018
@jcouv jcouv requested a review from a team as a code owner April 15, 2018 18:48
@jcouv jcouv changed the title Use compiler 2.8-beta3 and enable LangVersion 7.3 Use 2.8-beta3 toolset compiler and enable LangVersion 7.3 Apr 16, 2018
@jcouv
Copy link
Copy Markdown
Member Author

jcouv commented Apr 16, 2018

@VSadov @jaredpar @dotnet/roslyn-infrastructure for review. Thanks

@jasonmalinowski
Copy link
Copy Markdown
Member

jasonmalinowski commented Apr 16, 2018

@jcouv Given we're bumping langver, this would be requiring 15.7 Previews as a base for contribution, correct? If so, this needs updating to the contribution documents in this PR.

@jcouv
Copy link
Copy Markdown
Member Author

jcouv commented Apr 16, 2018

@jasonmalinowski Good catch. I'll do that.
Do we also have something in our build process that checks requirements, which I should update?

jasonmalinowski
jasonmalinowski requested changes Apr 16, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs updates to documentation.

@jasonmalinowski
Copy link
Copy Markdown
Member

jasonmalinowski commented Apr 16, 2018

@jcouv, not really. Normally updates like this are most deliberate and are deliberated on carefully. You'll probably want to reach out to the staff mailing list internally because we traditionally have held off doing this until we shipped a more stable preview. If that was a concern, I could see updating the command line compilers but not bumping langver.

jaredpar
jaredpar reviewed Apr 16, 2018
View reviewed changes
build/Targets/Packages.props
<MicrosoftNetRoslynDiagnosticsVersion>2.6.1-beta1-62702-01</MicrosoftNetRoslynDiagnosticsVersion>
<MicrosoftNetCoreILAsmVersion>2.0.0</MicrosoftNetCoreILAsmVersion>
<MicrosoftNETCoreCompilersVersion>2.8.0-beta2-62712-07</MicrosoftNETCoreCompilersVersion>
<MicrosoftNETCoreCompilersVersion>2.8.0-beta3</MicrosoftNETCoreCompilersVersion>
Copy link
Copy Markdown
Member

@jaredpar jaredpar Apr 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Finally in sync.

@jcouv
Copy link
Copy Markdown
Member Author

jcouv commented Apr 17, 2018

@jasonmalinowski Reverted the LangVersion change.
From the set of features in C# 7.3, we'd probably want ref local re-assignment, but we can wait until 15.7 RTM to do that.

@jcouv jcouv changed the title Use 2.8-beta3 toolset compiler and enable LangVersion 7.3 Use 2.8-beta3 toolset compiler Apr 17, 2018
@jcouv
Copy link
Copy Markdown
Member Author

jcouv commented Apr 18, 2018

@jasonmalinowski Good to go?

@jcouv jcouv merged commit 79fd5bd into dotnet:master Apr 18, 2018
@jcouv jcouv deleted the csharp-73 branch April 18, 2018 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

+1 more reviewer

@sharwell sharwell sharwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jcouv jcouv

Labels

Area-Infrastructure

Projects

None yet

Milestone

15.8

Development

Successfully merging this pull request may close these issues.

4 participants

@jcouv @jasonmalinowski @jaredpar @sharwell