Fix for UseDeconstruction with default literal#26140
Merged
jcouv merged 3 commits intodotnet:masterfrom Apr 16, 2018
Merged
Conversation
Contributor
Author
|
Tagging @jcouv @CyrusNajmabadi @jinujoseph who reviewed the original PR. |
Contributor
Author
|
Can we get this resolved soon so that I don't have to feel bad / ashamed about this for too long? 😄 |
Contributor
Author
|
retest windows_release_unit32_prtest please |
| if (conversion.Exists && | ||
| !conversion.IsIdentity && | ||
| !conversion.IsTupleConversion && | ||
| !conversion.IsTupleLiteralConversion) |
Contributor
There was a problem hiding this comment.
probably would benefit from a comment.
CyrusNajmabadi
approved these changes
Apr 13, 2018
Contributor
Author
|
retest windows_debug_vs-integration_prtest please |
jinujoseph
approved these changes
Apr 15, 2018
jcouv
approved these changes
Apr 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #25260
The previous PR #25282 didn't actually fix the issue with a default literal. The test (which asserts that "use deconstruction" isn't offered) actually passes because it is using the default language version - 7.0, which doesn't allow default literals, therefore the code is incorrect. With C# 7.1 enabled, it is offered (and shouldn't be). The implementation is wrong. It is currently checking the type of the expression but a default literal does have an inferred type.
The failure was discovered in #26115 where the test fails when default language version is changed to 8.0.