Change resource string (feedback from #25903)#26131
Merged
OmarTawfik merged 1 commit intodotnet:masterfrom Apr 13, 2018
OmarTawfik:fix-25944-resources-nit
Merged
Change resource string (feedback from #25903)#26131OmarTawfik merged 1 commit intodotnet:masterfrom OmarTawfik:fix-25944-resources-nit
OmarTawfik merged 1 commit intodotnet:masterfrom
OmarTawfik:fix-25944-resources-nit
Conversation
333fred
reviewed
Apr 13, 2018
| <target state="new">Invalid object creation</target> | ||
| <note /> | ||
| </trans-unit> | ||
| <trans-unit id="FTL_InvalidInputFileName"> |
Member
There was a problem hiding this comment.
Is it possible to keep the existing translations for these, since all that was changed was the id of the string? Or does it have to be "retranslated"? cc @tmeschter
Contributor
There was a problem hiding this comment.
I don't think there's an automatic way to keep the existing translation under a new ID, but it isn't a big deal. On their next pass, the Loc team will find the existing translation in their master database and reuse that for the "new" resource--no real work by a human will be required.
333fred
approved these changes
Apr 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #25944
cc @dotnet/roslyn-compiler