Skip to content

Remove dead NuGet code#26110

Merged
jaredpar merged 1 commit intodotnet:masterfrom
jaredpar:fix-deadcode
Apr 12, 2018
Merged

Remove dead NuGet code#26110
jaredpar merged 1 commit intodotnet:masterfrom
jaredpar:fix-deadcode

Conversation

@jaredpar
Copy link
Copy Markdown
Member

This is legacy localization code. Not needed anymore.

Ask Mode template not completed

Customer scenario

What does the customer do to get into this situation, and why do we think this
is common enough to address for this release. (Granted, sometimes this will be
obvious "Open project, VS crashes" but in general, I need to understand how
common a scenario is)

Bugs this fixes

(either VSO or GitHub links)

Workarounds, if any

Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW

Risk

This is generally a measure our how central the affected code is to adjacent
scenarios and thus how likely your fix is to destabilize a broader area of code

Performance impact

(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")

Is this a regression from a previous update?

Root cause analysis

How did we miss it? What tests are we adding to guard against it in the future?

How was the bug found?

(E.g. customer reported it vs. ad hoc testing)

Test documentation updated?

If this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.

This is legacy localization code. Not needed anymore.
@jaredpar jaredpar requested a review from a team as a code owner April 11, 2018 23:18
@jaredpar
Copy link
Copy Markdown
Member Author

CC @jasonmalinowski, @dotnet/roslyn-infrastructure for review

Copy link
Copy Markdown
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@jasonmalinowski
Copy link
Copy Markdown
Member

☠️ might also be an appropriate emoji.

@jaredpar jaredpar merged commit 94ef9a5 into dotnet:master Apr 12, 2018
@jaredpar jaredpar deleted the fix-deadcode branch August 21, 2018 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants