Skip to content

Fix stackalloc test broken in merge#25854

Merged
jcouv merged 1 commit intodotnet:masterfrom
jcouv:stackalloc-test
Mar 31, 2018
Merged

Fix stackalloc test broken in merge#25854
jcouv merged 1 commit intodotnet:masterfrom
jcouv:stackalloc-test

Conversation

@jcouv
Copy link
Copy Markdown
Member

@jcouv jcouv commented Mar 31, 2018

The behavior of stackalloc was modified in the master branch, and a test were added to the dev15.7.x branch (for stackalloc initializer feature). When the dev15.7.x test was merged to master, its expectations did not reflect the new logic from master branch.

Thanks @alrz for raising the issue.

Tagging @VSadov @dotnet/roslyn-compiler for review.

@jcouv jcouv added Area-Compilers Test Test failures in roslyn-CI labels Mar 31, 2018
@jcouv jcouv added this to the 15.8 milestone Mar 31, 2018
@jcouv jcouv self-assigned this Mar 31, 2018
@jcouv jcouv requested a review from a team as a code owner March 31, 2018 00:53
@jcouv jcouv mentioned this pull request Mar 31, 2018
Merged
@jcouv
Copy link
Copy Markdown
Member Author

jcouv commented Mar 31, 2018

FYI @dotnet/roslyn-infrastructure

@VSadov
Copy link
Copy Markdown
Member

VSadov commented Mar 31, 2018

We really should bring the stackalloc constant folding into 15.7.x

It is confusing that master is ahead of 15.7.x in terms of this fix.

It is not the first time we see bad merges because of this. The only difference is the older cases were caught in CI and re-resolved and this one somehow went through.

VSadov
VSadov approved these changes Mar 31, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcouv
Copy link
Copy Markdown
Member Author

jcouv commented Mar 31, 2018

test windows_debug_unit64_prtest please

@jcouv
Copy link
Copy Markdown
Member Author

jcouv commented Mar 31, 2018

test windows_debug_unit64_prtest please

@jcouv
Copy link
Copy Markdown
Member Author

jcouv commented Mar 31, 2018

windows_debug_unit64_prtest failed on editor tests without information (details)

FYI @dotnet/roslyn-infrastructure I'll re-run.

19:32:34 Errors Roslyn.Services.Editor2.UnitTests.dll: 
19:32:34 
19:32:34 Command: C:\Users\dotnet-bot\.nuget\packages\xunit.runner.console\2.3.1\tools\net452\xunit.console.exe "D:\j\workspace\windows_debug---f1572675\Binaries\Debug\UnitTests\EditorServicesTest2\Roslyn.Services.Editor2.UnitTests.dll"  -xml "D:\j\workspace\windows_debug---f1572675\Binaries\Debug\UnitTests\EditorServicesTest2\xUnitResults\Roslyn.Services.Editor2.UnitTests.dll.xml" -noshadow -verbose
19:32:34 xUnit output log: D:\j\workspace\windows_debug---f1572675\Binaries\Debug\Logs\Roslyn.Services.Editor2.UnitTests.dll.out.log
19:32:34 
xunit produced no error output but had exit code -1073740286

@jcouv jcouv merged commit 57272a2 into dotnet:master Mar 31, 2018
@jcouv jcouv deleted the stackalloc-test branch March 31, 2018 04:01
@VSadov VSadov mentioned this pull request Apr 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredpar jaredpar jaredpar approved these changes

@VSadov VSadov VSadov approved these changes

Assignees

@jcouv jcouv

Labels

Area-Compilers Area-Infrastructure Test Test failures in roslyn-CI

Projects

None yet

Milestone

15.8

Development

Successfully merging this pull request may close these issues.

3 participants

@jcouv @VSadov @jaredpar