Fix loc failures in IDE#25797
Conversation
The tests are using strings from libraries whose loc we don't control. Hence only running these in english. closes dotnet#25764
| } | ||
|
|
||
| [Fact, Trait(Traits.Feature, Traits.Features.Workspace)] | ||
| [ConditionalFact(typeof(IsEnglishLocal)), Trait(Traits.Feature, Traits.Features.Workspace)] |
There was a problem hiding this comment.
shouldn't this be called IsEnglishLocale?
There was a problem hiding this comment.
Yes it probably should.
There was a problem hiding this comment.
I also have a question about this. As I understand it, this will cause the tests to be skipped on a non-english culture, which doesn't seem like an ideal solution. The test should instead somehow enforce the culture to be en-US so that it runs on any machine.
There was a problem hiding this comment.
I agree in principal here. Right now though our primary goal is to get the Spanish Jenkins leg green and merged back into our production branches. This is important to
- Ensure our non-English contributors are unblocked.
- Ensure that we don't further regress any localization scenarios.
I'm trying to fix any tests that have obvious quick fixes. For others though I'm switching them to English only and leaving our localization bugs active to ensure we follow up on them.
We do have a mechanism for forcing the suite to run under English but it doesn't appear to be functioning correctly at the moment. That's why I'm using conditional execution on these items for now.
| End Function | ||
|
|
||
| <WpfFact> | ||
| <ConditionalWpfFact(GetType(IsEnglishLocal))> |
There was a problem hiding this comment.
Can you mention the tracking bug?
| { | ||
| double result; | ||
| if (!double.TryParse(data[j], out result)) | ||
| if (!double.TryParse(data[j], NumberStyles.Float | NumberStyles.AllowThousands, EnsureEnglishUICulture.PreferredOrNull, out result)) |
There was a problem hiding this comment.
@heejaechang @sharwell @ivanbasov Are the files guaranteed to be in the English locale during generation?
There was a problem hiding this comment.
Know the IDE team typically prefers current culture over the compiler preference of forcing English. In this case though the CSV files are checked into the code base and exposed as an embedded resource. Hence we need to pick a fixed culture to use during parse here as they copy will always be in a single locale.
|
test windows_debug_spanish_unit32_prtest please |
|
@dotnet/roslyn-compiler please review. Really small test change. |
No description provided.