Skip to content

Allowing multiple exposed line spans in VS style options preview#25574

Merged
jinujoseph merged 7 commits intodotnet:masterfrom
Neme12:optionPreview
Apr 17, 2018
Merged

Allowing multiple exposed line spans in VS style options preview#25574
jinujoseph merged 7 commits intodotnet:masterfrom
Neme12:optionPreview

Conversation

@Neme12
Copy link
Copy Markdown
Contributor

@Neme12 Neme12 commented Mar 18, 2018

fixes #25573

@Neme12 Neme12 requested a review from a team as a code owner March 18, 2018 21:11
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented Mar 18, 2018

This is great. thanks!

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented Mar 18, 2018

Tagging @dotnet/roslyn-ide @jinujoe

@Neme12 Neme12 changed the title Allowing multiple exposed line spans in VS code style options Allowing multiple exposed line spans in VS style options preview Mar 18, 2018
@Neme12
Copy link
Copy Markdown
Contributor Author

Neme12 commented Mar 19, 2018

@CyrusNajmabadi I think you meant @jinujoseph ?

@Neme12
Copy link
Copy Markdown
Contributor Author

Neme12 commented Mar 20, 2018

retest windows_release_vs-integration_prtest please

@Neme12
Copy link
Copy Markdown
Contributor Author

Neme12 commented Mar 28, 2018 •
edited
Loading

@jinujoseph Is this something that could get accepted for the IDE or is this too petty & insignificant?

@jinujoseph
Copy link
Copy Markdown
Contributor

jinujoseph commented Mar 28, 2018

Every little improvement counts and i like this !!
Adding @sharwell , @Pilchie , @kuhlenh if they think otherwise

@Pilchie
Copy link
Copy Markdown
Member

Pilchie commented Mar 29, 2018

We can definitely take this in master (for 15.8). Definitely appreciate every little bit of love and polish we can get, even if we don't have time to fix them all ourselves!

@Neme12
Copy link
Copy Markdown
Contributor Author

Neme12 commented Mar 29, 2018

retest windows_release_vs-integration_prtest please

@Neme12
Copy link
Copy Markdown
Contributor Author

Neme12 commented Mar 30, 2018

retest windows_debug_vs-integration_prtest please

@Neme12
Copy link
Copy Markdown
Contributor Author

Neme12 commented Mar 30, 2018

retest windows_debug_unit64_prtest please

@jcouv jcouv added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Mar 30, 2018
@Neme12
Copy link
Copy Markdown
Contributor Author

Neme12 commented Apr 3, 2018

@dotnet-bot retest windows_release_vs-integration_prtest please

@Neme12
Copy link
Copy Markdown
Contributor Author

Neme12 commented Apr 6, 2018

retest windows_debug_vs-integration_prtest please

@jcouv jcouv added this to the 15.8 milestone Apr 16, 2018
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Apr 16, 2018

@jinujoseph Good to merge?

@jinujoseph jinujoseph merged commit a3bcda8 into dotnet:master Apr 17, 2018
@jinujoseph
Copy link
Copy Markdown
Contributor

jinujoseph commented Apr 17, 2018

thanks @Neme12

@Neme12 Neme12 deleted the optionPreview branch April 17, 2018 08:52
@sharwell sharwell mentioned this pull request May 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@jinujoseph jinujoseph jinujoseph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

15.8

Development

Successfully merging this pull request may close these issues.

Bad highlighting in VS style options preview

5 participants

@Neme12 @CyrusNajmabadi @jinujoseph @Pilchie @jcouv