Skip to content

Add tests for blocking issues#25180

Merged
agocke merged 1 commit intodotnet:features/ref-reassignmentfrom
agocke:ide-ref-foreach-support
Mar 5, 2018
Merged

Add tests for blocking issues#25180
agocke merged 1 commit intodotnet:features/ref-reassignmentfrom
agocke:ide-ref-foreach-support

Conversation

@agocke
Copy link
Copy Markdown
Member

@agocke agocke commented Mar 2, 2018

This includes tests for

  • Language version checks for ref in for & foreach
  • Additional tests around unary plus and ref assignment expressions
  • Tests for ?., IDisposable, and ref assignment expressions
  • Additional semantic model tests
  • Additional IOperation tests

This includes tests for

- Language version checks for ref in for & foreach
- Additional tests around unary plus and ref assignment expressions
- Tests for ?., IDisposable, and ref assignment expressions
- Additional semantic model tests
- Additional IOperation tests
@agocke agocke requested review from a team and VSadov March 2, 2018 00:59
@agocke agocke requested a review from a team as a code owner March 2, 2018 00:59
@agocke
Copy link
Copy Markdown
Member Author

agocke commented Mar 5, 2018

ping @dotnet/roslyn-compiler for review

Copy link
Copy Markdown
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Copy Markdown
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agocke agocke merged commit 92eb099 into dotnet:features/ref-reassignment Mar 5, 2018
@agocke agocke deleted the ide-ref-foreach-support branch March 5, 2018 21:07
@jcouv jcouv mentioned this pull request Mar 5, 2018
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants