Skip to content

made service hub to log more detail info on certain exception#24676

Merged
heejaechang merged 1 commit intodotnet:dev15.7.xfrom
heejaechang:improveLog
Feb 7, 2018
Merged

made service hub to log more detail info on certain exception#24676
heejaechang merged 1 commit intodotnet:dev15.7.xfrom
heejaechang:improveLog

Conversation

@heejaechang
Copy link
Copy Markdown
Contributor

Customer scenario

There is no user visible behavior change.

Bugs this fixes

this is to improve logging to help investigating this kind of feedback
https://developercommunity.visualstudio.com/content/problem/191806/visual-studio-ide-crashes-as-soon-as-any-solution.html

Workarounds, if any

No

Risk

N/A

Performance impact

N/A

Is this a regression from a previous update?

No

Root cause analysis

Current log doesn't log important information such as fusion log or loader exception information. which make it a bit harder to find out what the root cause is for this kind of feedback (https://developercommunity.visualstudio.com/content/problem/191806/visual-studio-ide-crashes-as-soon-as-any-solution.html)

How was the bug found?

feedback

@heejaechang heejaechang requested a review from a team as a code owner February 6, 2018 21:38
@heejaechang
Copy link
Copy Markdown
Contributor Author

@jinujoseph @Pilchie approval for 15.7? simple change. added more information on service hub log.

@Pilchie
Copy link
Copy Markdown
Member

Pilchie commented Feb 7, 2018

Approved.

@heejaechang heejaechang merged commit 3362876 into dotnet:dev15.7.x Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants