Skip to content

Merge dev15.5.x to dev15.6.x#24660

Merged
AbhitejJohn merged 6 commits intodev15.6.xfrom
merges/dev15.5.x-to-dev15.6.x-20180206-080005
Feb 6, 2018
Merged

Merge dev15.5.x to dev15.6.x#24660
AbhitejJohn merged 6 commits intodev15.6.xfrom
merges/dev15.5.x-to-dev15.6.x-20180206-080005

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is an automatically generated pull request from dev15.5.x into dev15.6.x.

git fetch --all
git checkout merges/dev15.5.x-to-dev15.6.x-20180206-080005
git reset --hard upstream/dev15.6.x
git merge upstream/dev15.5.x
# Fix merge conflicts
git commit
git push merges/dev15.5.x-to-dev15.6.x-20180206-080005 --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

@dotnet-bot dotnet-bot requested review from a team as code owners February 6, 2018 08:00
@AbhitejJohn
Copy link
Copy Markdown
Contributor

Tagging @mavasani to help with the build failures. It looks like we need much more than a "choose dev15.6.x" only to fix the merge conflict. Can you help with fixing this fully please?

@mavasani
Copy link
Copy Markdown
Contributor

mavasani commented Feb 6, 2018

@AbhitejJohn I would recommend starting with "choose dev15.5.x" to fix the merge conflicts. Unshipped.txt files should only contain public APIs that were added as post dev15.5.x

AbhitejJohn and others added 3 commits February 6, 2018 12:33
Choosing dev15.5.x as the base instead.
Choosing dev15.5.x as the base instead.
@AbhitejJohn
Copy link
Copy Markdown
Contributor

@mavasani : I think I got it. Can you review please?

Copy link
Copy Markdown
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@AbhitejJohn AbhitejJohn merged commit a61aa8b into dev15.6.x Feb 6, 2018
@AbhitejJohn AbhitejJohn deleted the merges/dev15.5.x-to-dev15.6.x-20180206-080005 branch February 6, 2018 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants