Do not do analysis for invalid argument escape mixing when having binding errors.#24656
Merged
VSadov merged 1 commit intodotnet:dev15.7.xfrom Feb 6, 2018
Merged
Do not do analysis for invalid argument escape mixing when having binding errors.#24656VSadov merged 1 commit intodotnet:dev15.7.xfrom
VSadov merged 1 commit intodotnet:dev15.7.xfrom
Conversation
Member
Author
|
@dotnet/roslyn-compiler - please review |
Member
Author
|
@dotnet/roslyn-compiler - PING. Simple fix for a crash. (targeting 15.7.x) |
cston
approved these changes
Feb 6, 2018
Member
Author
|
CC:@jaredpar - for the ask mode approval. |
Member
|
approved |
Member
Author
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:#24627
Customer scenario
Customer types code that involves calling methods on a ref-like type and makes a mistake calling an instance method as if it is a static method.
This should just produce a compile error. Instead compiler crashes.
Bugs this fixes
#24627
Workarounds, if any
Not type this kind of code.
Risk
Low. We just check if we already in an error state before continuing with analysis.
Performance impact
Low perf impact because no extra allocations/no complexity changes
Is this a regression from a previous update?
No
Root cause analysis
Escape analysis checks the node for errors before doing analysis. In this scenario the analysis happens when outer node is not created yet, so it is slightly different and was missed.
Added tests.
How was the bug found?
customer reported
Test documentation updated?
N/A