Port fix for duplicate IDEDiagnosticIDs to 15.7#24648
Merged
chborl merged 3 commits intodotnet:dev15.7.xfrom Feb 6, 2018
Merged
Port fix for duplicate IDEDiagnosticIDs to 15.7#24648chborl merged 3 commits intodotnet:dev15.7.xfrom
chborl merged 3 commits intodotnet:dev15.7.xfrom
Conversation
jasonmalinowski
approved these changes
Feb 5, 2018
Contributor
Author
|
@jasonmalinowski @sharwell for approval. Nothing changed from the previously approved PR, just retargeted to dev15.7.x. |
sharwell
approved these changes
Feb 5, 2018
Contributor
|
@Pilchie for ask mode approval |
Member
|
Approved - but we really need to add some static analysis to stop this from happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backporting #24590 to 15.7
Original template copied here:
Customer scenario
Both the Validate Format String and Remove Unreachable Code analyzers use the same ID, so a user would see the same code for both of these issues and if they suppress either one it would suppress both.
Bugs this fixes
#23983
Workarounds, if any
none
Risk
No code risk, but it is a breaking change. If a customer previously suppressed the Validate Format String analzyer, it would start firing again because it has a new ID number. @kuhlenh will change it in our documentation and add it to the breaking change log.
Performance impact
none
Is this a regression from a previous update?
no
Root cause analysis
How was the bug found?
Test documentation updated?