Skip to content

Update optimization data to 2.7.0-beta3-62526-01...#24592

Merged
KevinH-MS merged 3 commits intodev15.6.xfrom
dev/kevinh/optprof
Feb 5, 2018
Merged

Update optimization data to 2.7.0-beta3-62526-01...#24592
KevinH-MS merged 3 commits intodev15.6.xfrom
dev/kevinh/optprof

Conversation

@KevinH-MS
Copy link
Contributor

@KevinH-MS KevinH-MS commented Feb 2, 2018 •
edited
Loading

Customer scenario

All VB/C# scenarios

Bugs this fixes

https://devdiv.visualstudio.com/DevDiv/_workitems/edit/498615
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/533397
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/559121
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/547161

Workarounds, if any

None

Risk

Negligible

Performance impact

Improves elapsed time and image size for several scenarios

Is this a regression from a previous update?

Yes

Root cause analysis

Optprof updates are not automated

How was the bug found?

RPS

Test documentation updated?

N/A

@KevinH-MS KevinH-MS requested a review from a team as a code owner February 2, 2018 00:40
jasonmalinowski
jasonmalinowski approved these changes Feb 2, 2018
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume you'll try some RPS run in advance to see what this helps/hurts?

@KevinH-MS
Copy link
Contributor Author

KevinH-MS commented Feb 2, 2018

@jasonmalinowski yeah, here were the initial results: http://ddweb/dashboard/vsbuild/detail/val/27401.9000.kevinh.180201.190935

Everything is good except "open winform" 🤕 I've retrained the LanguageServices dlls (again) and will queue a new build.

FYI:

Name Baseline Current Delta
Microsoft.CodeAnalysis.EditorFeatures.Wpf.ni.dll 3,092,480 1,101,824 -1,990,656

@KevinH-MS KevinH-MS added this to the 15.6 milestone Feb 5, 2018
@KevinH-MS KevinH-MS added the Tenet-Performance Regression in measured performance of the product from goals. label Feb 5, 2018
@KevinH-MS
Copy link
Contributor Author

KevinH-MS commented Feb 5, 2018

Latest RPS results look good.

FYI @MattGertz for escrow approval

@MattGertz
Copy link
Contributor

MattGertz commented Feb 5, 2018

@KevinH-MS Thanks. Please add the VSO PR link to each of the VSO bugs you list up top, and then tag me so I can submit them. We'll need to move fast on these submissions as we are close to the wire.

@jinujoseph
Copy link
Contributor

jinujoseph commented Feb 5, 2018

@KevinH-MS i can help with the bugs submission

@natidea
Copy link
Contributor

natidea commented Feb 5, 2018

Approved to merge via https://devdiv.visualstudio.com/DevDiv/_workitems/edit/498615

@KevinH-MS KevinH-MS merged commit 82b4b19 into dev15.6.x Feb 5, 2018
@KevinH-MS KevinH-MS deleted the dev/kevinh/optprof branch February 5, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees

No one assigned

Labels

Approved to merge Tenet-Performance Regression in measured performance of the product from goals.

Projects

None yet

Milestone

15.6

Development

Successfully merging this pull request may close these issues.

5 participants

@KevinH-MS @MattGertz @jinujoseph @natidea @jasonmalinowski