CheckPresenceOfTypeIdentifierAttribute - avoid requesting syntax trees if we know that we already decoded all well-known attributes.#24576
Merged
AlekseyTs merged 1 commit intodotnet:dev15.6.xfrom Feb 2, 2018
Conversation
…s if we know that we already decoded all well-known attributes. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems?id=537870.
Contributor
Author
|
@dotnet/roslyn-compiler Please review a fix for a perf regression in 15.6 |
1 similar comment
Contributor
Author
|
@dotnet/roslyn-compiler Please review a fix for a perf regression in 15.6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems?id=537870.
Customer scenario
Compilers unnecessary request syntax trees, which has negative perf impact for some IDE scenarios when the trees are unloaded from memory.
Bugs this fixes
https://devdiv.visualstudio.com/DevDiv/_workitems?id=537870
Workarounds, if any
None
Risk
Low, very localized, simple fix. The code path has good code coverage by unit-tests.
Performance impact
Should improve performance because no extra allocations/no complexity changes and the fix prevents compiler from doing unnecessary work.
Is this a regression from a previous update?
Yes.
Root cause analysis
Caught by an existing RPS test
How was the bug found?
Caught by an existing RPS test
Test documentation updated?
N/A