NormalizeWhitespace: no need for space after colon in interpolation format clause#24494
Merged
jcouv merged 1 commit intodotnet:dev15.7.xfrom Jan 29, 2018
Merged
NormalizeWhitespace: no need for space after colon in interpolation format clause#24494jcouv merged 1 commit intodotnet:dev15.7.xfrom
jcouv merged 1 commit intodotnet:dev15.7.xfrom
Conversation
30c45da to
f735405
Compare
sharwell
approved these changes
Jan 27, 2018
Contributor
|
@jcouv Why for personal review only? |
Member
Author
|
@sharwell I usually wait to get an initial green CI before opening up for review, in case there are regressions I didn't test locally. |
CyrusNajmabadi
approved these changes
Jan 28, 2018
jinujoseph
approved these changes
Jan 28, 2018
Contributor
|
@Pilchie for ask mode approval |
Member
Author
|
@dotnet/roslyn-compiler for review. |
cston
approved these changes
Jan 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer scenario
Invoke
NormalizeWhitespaceon string interpolation with format, such as:N. No space should be injected after the colon.Bugs this fixes
Fixes #24454