Publish manifest for orchestrated build#24483
Conversation
Changes our blob publish to include the manifest file. Needed by more recent versions of product build. Also decided to just link our two msbuild files together via MSBuild task vs. a powershell script. The point of microbuild.ps1 is to test as much as possible in our jenkins build. There is no way to actually test blob publishing in Jenkins hence this indirection was just causing problems, not helping anything.
|
Keeping this as WIP until I can get a couple of official builds completed to verify te changes. |
| ManifestCommit="$(CommitHashDisplay)" | ||
| ManifestName="roslyn" | ||
| SkipCreateManifest="false" /> | ||
| /> |
There was a problem hiding this comment.
I will not code before finishing coffee
I will not code before finishing coffee
I will not code before finishing coffee
| ManifestBuildId="$(BUILD_BUILDNUMBER)" | ||
| ManifestCommit="$(CommitHashDisplay)" | ||
| ManifestName="roslyn" | ||
| SkipCreateManifest="false" /> |
There was a problem hiding this comment.
SkipCreateManifest is optional and defaults to false, not needed. (But doesn't hurt anything of course.)
|
CC @dotnet/roslyn-infrastructure for review |
|
@jaredpar Is this the right branch? The branch listed for roslyn is dev15.7x-vs-deps. |
|
@mmitche yes and yes. This branch auto-merges into dev15.7.x-vs-deps. The vs-deps branch is only editted directly if the change depends on unreleased versions of VS binaries. |
|
@jaredpar Not seeing that auto-merge. When should it happen? |
|
It should have happened at most 24 hours after merge. @jasonmalinowski are the merges stuck? |
|
Yup, I'm working through the PRs right now, so it should be merged shortly. FYI I do them every weekday morning, so if you merge something Friday you won't see it until Monday. |
Changes our blob publish to include the manifest file. Needed by more
recent versions of product build.
Also decided to just link our two msbuild files together via MSBuild
task vs. a powershell script. The point of microbuild.ps1 is to test as
much as possible in our jenkins build. There is no way to actually test
blob publishing in Jenkins hence this indirection was just causing
problems, not helping anything.