fixing AccessViolationException on ReadMetadataHeader#24464
Merged
ivanbasov merged 2 commits intodotnet:dev15.6.xfrom Feb 2, 2018
Merged
fixing AccessViolationException on ReadMetadataHeader#24464ivanbasov merged 2 commits intodotnet:dev15.6.xfrom
ivanbasov merged 2 commits intodotnet:dev15.6.xfrom
Conversation
Contributor
Author
|
Tagging @r-ramesh for review |
cston
approved these changes
Jan 31, 2018
r-ramesh
approved these changes
Jan 31, 2018
Contributor
|
pending barcheck approval for 15.6 |
Contributor
|
N.B. This is currently targeting dev15.7.x, but is submitted for 15.6 |
Contributor
|
@ivanbasov approved to merge via link can you retarget to 15.6 branch pls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer scenario
The user debugging process crashed during the execution
roslyn/src/ExpressionEvaluator/Core/Source/ExpressionCompiler/DkmUtilities.cs
Line 63 in f9ebce0
roslyn/src/ExpressionEvaluator/Core/Source/ExpressionCompiler/DkmUtilities.cs
Line 61 in f9ebce0
The debugger crashes with
CLR_EXCEPTION_System.AccessViolationException_80004003_System.Reflection.Metadata.dll!System.Reflection.Metadata.MetadataReader.ReadMetadataHeader
Bugs this fixes
VSO 187805
Workarounds, if any
No
Risk
Low
Performance impact
No
Is this a regression from a previous update?
No
Root cause analysis
This happens on the edge between Roslyn, Visual Studio and user debugging processes. There are various interactions between processes with different timings. Not all of them were considered.
How was the bug found?
Watson