Skip to content

Merge dev15.6.x into dev15.6.x-vs-deps#24441

Merged
jasonmalinowski merged 9 commits intodotnet:dev15.6.x-vs-depsfrom
jasonmalinowski:merge-dev15.6.x-into-dev15.6.x-vs-deps
Jan 25, 2018
Merged

Merge dev15.6.x into dev15.6.x-vs-deps#24441
jasonmalinowski merged 9 commits intodotnet:dev15.6.x-vs-depsfrom
jasonmalinowski:merge-dev15.6.x-into-dev15.6.x-vs-deps

Conversation

@jasonmalinowski
Copy link
Copy Markdown
Member

Merging last changes prior to final insertion.

@jasonmalinowski jasonmalinowski requested review from a team as code owners January 25, 2018 03:53
@jasonmalinowski jasonmalinowski changed the base branch from master to dev15.6.x-vs-deps January 25, 2018 03:53
@heejaechang
Copy link
Copy Markdown
Contributor

retest windows_debug_unit64_prtest please

@heejaechang
Copy link
Copy Markdown
Contributor

heejaechang commented Jan 25, 2018

looking into integration test failure.

all failed with this.
..

System.Runtime.Serialization.SerializationException: Type 'Microsoft.VisualStudio.Composition.CompositionFailedException' in Assembly 'Microsoft.VisualStudio.Composition, Version=15.3.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' is not marked as serializable.

Server stack trace:
at System.Runtime.Serialization.Formatters.Binary.WriteObjectInfo.InitSerialize(Object obj, ISurrogateSelector surrogateSelector, StreamingContext context, SerObjectInfoInit serObjectInfoInit, IFormatterConverter converter, ObjectWriter objectWriter, SerializationBinder binder)
at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.Write(WriteObjectInfo objectInfo, NameInfo memberNameInfo, NameInfo typeNameInfo)
at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.Serialize(Object graph, Header[] inHeaders, __BinaryWriter serWriter, Boolean fCheck)
at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize(Stream serializationStream, Object graph, Header[] headers, Boolean fCheck)
at System.Runtime.Remoting.Channels.BinaryServerFormatterSink.SerializeResponse(IServerResponseChannelSinkStack sinkStack, IMessage msg, ITransportHeaders& headers, Stream& stream)
at System.Runtime.Remoting.Channels.BinaryServerFormatterSink.ProcessMessage(IServerChannelSinkStack sinkStack, IMessage requestMsg, ITransportHeaders requestHeaders, Stream requestStream, IMessage& responseMsg, ITransportHeaders& responseHeaders, Stream& responseStream)

Exception rethrown at [0]:
at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg).GetType().Name

Server stack trace:
at System.Runtime.Serialization.Formatters.Binary.WriteObjectInfo.InitSerialize(Object obj, ISurrogateSelector surrogateSelector, StreamingContext context, SerObjectInfoInit serObjectInfoInit, IFormatterConverter converter, ObjectWriter objectWriter, SerializationBinder binder)
at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.Write(WriteObjectInfo objectInfo, NameInfo memberNameInfo, NameInfo typeNameInfo)
at System.Runtime.Serialization.Formatters.Binary.ObjectWriter.Serialize(Object graph, Header[] inHeaders, __BinaryWriter serWriter, Boolean fCheck)
at System.Runtime.Serialization.Formatters.Binary.BinaryFormatter.Serialize(Stream serializationStream, Object graph, Header[] headers, Boolean fCheck)
at System.Runtime.Remoting.Channels.BinaryServerFormatterSink.SerializeResponse(IServerResponseChannelSinkStack sinkStack, IMessage msg, ITransportHeaders& headers, Stream& stream)
at System.Runtime.Remoting.Channels.BinaryServerFormatterSink.ProcessMessage(IServerChannelSinkStack sinkStack, IMessage requestMsg, ITransportHeaders requestHeaders, Stream requestStream, IMessage& responseMsg, ITransportHeaders& responseHeaders, Stream& responseStream)

Exception rethrown at [0]:
at System.Runtime.Remoting.Proxies.RealProxy.HandleReturnMessage(IMessage reqMsg, IMessage retMsg)

@heejaechang
Copy link
Copy Markdown
Contributor

dump has nothing useful. building locally to run test

@heejaechang
Copy link
Copy Markdown
Contributor

passed locally. machine issue?

@heejaechang
Copy link
Copy Markdown
Contributor

okay, found reason. integration test fails for d15.5 drop. it only works for d15.6stg drop. due to this

----- Catalog construction errors -----
Error #1
Microsoft.VisualStudio.Composition.PartDiscoveryException: Failure while scanning type "Microsoft.VisualStudio.ConnectedServices.MobileApps.Handlers.CordovaMobileAppHandler". ---> System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.VisualStudio.ApacheCordovaTools.Definitions.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' or one of its dependencies. The system cannot find the file specified.
at System.Signature.GetSignature(Void* pCorSig, Int32 cCorSig, RuntimeFieldHandleInternal fieldHandle, IRuntimeMethodInfo methodHandle, RuntimeType declaringType)
at System.Signature..ctor(IRuntimeFieldInfo fieldHandle, RuntimeType declaringType)
at System.Reflection.RtFieldInfo.get_FieldType()
at Microsoft.VisualStudio.Composition.ReflectionHelpers.GetMemberType(MemberInfo fieldOrPropertyOrType)
at Microsoft.VisualStudio.Composition.AttributedPartDiscoveryV1.AddImportsFromMembers(PropertyInfo[] declaredProperties, FieldInfo[] declaredFields, TypeRef partTypeRef, IList`1 imports)
at Microsoft.VisualStudio.Composition.AttributedPartDiscoveryV1.CreatePart(Type partType, Boolean typeExplicitlyRequested)
at Microsoft.VisualStudio.Composition.PartDiscovery.CombinedPartDiscovery.CreatePart(Type partType, Boolean typeExplicitlyRequested)
at Microsoft.VisualStudio.Composition.PartDiscovery.<>c__DisplayClass27_0.b__0(Type type)
--- End of inner exception stack trace ---
----- CompositionError level 1 ------
Microsoft.VisualStudio.ProjectServices.DesignTimeBuildService.DesignTimeBuildHost: expected exactly 1 export of Microsoft.VisualStudio.ProjectServices.IVsDesignTimeBuildHost but found 0.
part definition Microsoft.VisualStudio.ProjectServices.DesignTimeBuildService

@heejaechang
Copy link
Copy Markdown
Contributor

retest this please

@heejaechang
Copy link
Copy Markdown
Contributor

hmmm.. still can't enqueue new integration test.

@jasonmalinowski
Copy link
Copy Markdown
Member Author

@heejaechang Integration tests can't run in -vs-deps since we don't have a new image yet for the latest command handler changes. We need to fix that.

Why they are running here I don't know...those were supposed to have been disabled.

@jasonmalinowski jasonmalinowski merged commit 8d2732e into dotnet:dev15.6.x-vs-deps Jan 25, 2018
@jasonmalinowski jasonmalinowski deleted the merge-dev15.6.x-into-dev15.6.x-vs-deps branch January 25, 2018 06:58
@heejaechang
Copy link
Copy Markdown
Contributor

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants