Localization test failures 2#24424
Conversation
|
|
||
| Assert.Equal(2, numRetries) ' Ensure that we actually retried and that we bailed out on the second retry if the same identity was seen in the diagnostics. | ||
| Assert.Equal($"error BC30652: Reference required to assembly '{missingIdentity}' containing the type 'MissingType'. Add one to your project.", errorMessage) | ||
| Assert.Equal($"error BC30652: { String.Format(VBResources.ERR_UnreferencedAssembly3, missingIdentity, "MissingType")}", errorMessage) |
There was a problem hiding this comment.
💡 Use string instead of String. I can do a clean-up pass on the entire solution after the tests are fixed.
|
Requesting a second review from @dotnet/roslyn-interactive |
|
@dotnet/roslyn-interactive I'm planning to merge this one today unless I hear otherwise from one of you 😉 |
|
@sharwell This PR was merged without getting required sign-offs from the compiler team and it doesn't deal with localization issues in the manner that other compiler tests do. I think it should be reverted and different fixes should be made. |
|
@AlekseyTs This pull request did not touch compiler code. |
|
This PR touched Expression Compiler tests, even though they are not under Compilers folder, they used to be owned by Compiler team at some point. @jaredpar To clarify the current ownership for the tests. |
Fix for #23837.
Follow up for #24407.
This is the second of a series of PRs meant to resolve the unit test failures caused by missing localizations.
This PR includes test related to expression compiler
Roslyn.ExpressionEvaluator.CSharp.ExpressionCompiler.UnitTests
Done. Tested local (de-DE) and CI (en-US).
Roslyn.ExpressionEvaluator.VisualBasic.ExpressionCompiler.UnitTests
Done. Tested local (de-DE) and CI (en-US).