Move compiler core tests to use netstandard2.0 RTM#24393
Merged
jaredpar merged 6 commits intodotnet:dev15.7.xfrom Jan 23, 2018
Merged
Move compiler core tests to use netstandard2.0 RTM#24393jaredpar merged 6 commits intodotnet:dev15.7.xfrom
jaredpar merged 6 commits intodotnet:dev15.7.xfrom
Conversation
This changes the reference assemblies we use for the CoreClr compiler compilation to be Net Standard 2.0 RTM. Previously they were a beta version. This did mean a number of tests had to be moved to be desktop specific again. This is primarily due to the presence of ValueTuple as a default type in Net Standard 2.0. Tests that relied on ValueTuple not being defined had to be moved to net461 which doesn't have that type defined by default.
Now that the netstandard2.0 references are available via the MS.CA.Test.Reosurces.Proprietary NuGet package we no longer need to copy them around on the file system (that's where they were previously being referenced from).
It was still relying on the 'ref' directory. Changed it to use the resource image.
Member
Author
|
CC @dotnet/roslyn-compiler for review. |
cston
approved these changes
Jan 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the compiler tests to use the netstandard2.0 RTM binaries when creating in memory compilations. This does mean a few of our tests had to move back to targeting desktop due to a change in the set of types available. For example
ValueTupleis present by default in netstandard2.0 and hence any tests that depended on adding it, or it's presence being absent, had to move back to target net46 for now.