Skip to content

'Use local function' suppress if used in expression tree.#24391

Merged
sharwell merged 1 commit intodotnet:dev15.6.xfrom
MaStr11:UseLocalFunction_SuppressIfConvertedToExpression
Jan 23, 2018
Merged

'Use local function' suppress if used in expression tree.#24391
sharwell merged 1 commit intodotnet:dev15.6.xfrom
MaStr11:UseLocalFunction_SuppressIfConvertedToExpression

Conversation

@MaStr11
Copy link
Copy Markdown
Contributor

@MaStr11 MaStr11 commented Jan 23, 2018

Test case for #24344. Just an additional test case that verifies that this was already fixed in #23136.

Closes #24344

@MaStr11 MaStr11 requested a review from a team as a code owner January 23, 2018 09:52
@sharwell sharwell changed the base branch from master to dev15.6.x January 23, 2018 14:12
@sharwell sharwell force-pushed the UseLocalFunction_SuppressIfConvertedToExpression branch from 6f68b00 to dd83cd1 Compare January 23, 2018 14:15
@sharwell
Copy link
Copy Markdown
Contributor

Rebased and retargeted this test-only change.

@sharwell sharwell self-assigned this Jan 23, 2018
@sharwell sharwell added this to the 15.6 milestone Jan 23, 2018
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharwell The work item number is wrong here (22672 instead of 24344). I think I can't correct it because you changed the target branch and if I push it will bring other changes with it. Can you correct this or should we leave it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I can fix it thanks :)

@sharwell sharwell force-pushed the UseLocalFunction_SuppressIfConvertedToExpression branch from dd83cd1 to cbe7a5f Compare January 23, 2018 19:53
@sharwell
Copy link
Copy Markdown
Contributor

Fixed and just waiting for tests to pass now

@sharwell sharwell merged commit c179663 into dotnet:dev15.6.x Jan 23, 2018
@MaStr11 MaStr11 deleted the UseLocalFunction_SuppressIfConvertedToExpression branch March 2, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants