Updated summaries#23989
Updated summaries#23989jinujoseph merged 2 commits intodotnet:masterfrom shaggygi:update-cref-wording
Conversation
|
|
||
| /// <summary> | ||
| /// Create a new instance of an <see cref="MSBuildProjectLoader"/>. | ||
| /// Create a new instance of a <see cref="MSBuildProjectLoader"/>. |
There was a problem hiding this comment.
Technically, 'an' is correct since MS is pronounced "em ess", and that leads with a vowel sound... 😄
(English is a terrible language.)
| /// <summary> | ||
| /// A service which enables searching for packages matching certain criteria. | ||
| /// It works against an <see cref="Microsoft.CodeAnalysis.Elfie"/> database to find results. | ||
| /// It works against a <see cref="Microsoft.CodeAnalysis.Elfie"/> database to find results. |
There was a problem hiding this comment.
Curious on this case and others -- if this gets rendered as just "Elfie" in the final display of the comment, you'd want it 'an'....I'm not sure what is right though.
There was a problem hiding this comment.
Yeah. this is tricky :) I know i picked 'an' here because in my mind i was saying "an Elfie database". But it really depends on final rendering.
|
@shaggygi: we'll need to resolve the merge conflicts here before merging this. Do you mind if we resolve and push to your PR branch? |
|
@jasonmalinowski sure. Do whatever is needed. Does it require anything on my end? |
|
@shaggygi: just that. GitHub lets me push to your branch in your repo (but just that branch) because of this PR; I just wanted to let you know before we do that it's happening. |
|
@jinujoseph Ask mode approval? Just changing some doc comment grammar. |
|
Approved to merge for 15.8.Preview3 |
|
test windows_release_vs-integration_prtest |
Updated wording in summaries.