Customer scenario

"Use auto property" code fix is provided for properties explicit interface implementations. The code fix generated invalid code. This fix suppress the code fixer for those properties.

Bugs this fixes

Fixes #23735

Workarounds, if any

Don't use the code fix.

Risk

Low.

Performance impact

The change causes an allocation of an immutable array on each "AnalyzeProperty" run.

Is this a regression from a previous update?

No.

Root cause analysis

Case wasn't covered by unit tests.

How was the bug found?

Customer reported

Test documentation updated?

No.

Remark

As discussed in #23735 (comment) there are cases where the analyzer actually could fix explicit implemented properties too, but this would probably do more harm than good. It would only work for read/write properties and every access to the backing field needs to be replaced by a cast to the interface:

namespace RoslynSandbox
{
    public interface IFoo
    {
        object Bar
        {
            get;
            set;
        }
    }
    internal class Foo : IFoo
    {
        private object bar;

        object IFoo.Bar
        {
            get
            {
                return this.bar;
            }
            set
            {
                this.bar = value;
            }
        }

        private void M()
        {
            this.bar = null;
        }
    }
}

namespace RoslynSandbox
{
    public interface IFoo
    {
        object Bar
        {
            get;
            set;
        }
    }
    internal class Foo : IFoo
    {
        object IFoo.Bar
        {
            get;
            set;
        }

        private void M()
        {
            ((IFoo)this).Bar = null;
        }
    }
}