LOC CHECKIN | dotnet/roslyn-master | 20171212#23744
Merged
tmeschter merged 3 commits intodotnet:masterfrom Dec 13, 2017
Merged
Conversation
Contributor
Author
|
Didn't realize I could update #23742. I have done so, and will close this PR. |
One of the VB scripting tests changes the default culture to "de-DE" and later prints out a string subject to localization. Now that we actually have satellite assemblies with real translations where the runtime will find them, we're getting the German version rather than the English version. The fix here is to simply update the baseline.
Contributor
Author
|
The source branch for #23742 disappeared before I could push the latest fix, so I've had to reopen this PR. |
Contributor
Author
|
@jasonmalinowski Could you take a look at this? It's the same as #23742 but with the one broken unit test fixed up. |
jasonmalinowski
approved these changes
Dec 13, 2017
Member
|
@tmeschter Let's merge this! |
Member
|
well I think most of PRs just got conflicted. this is not great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #23742, with further updates.