Minor update for 'Generate delegate constructor' refactoring#23466
Merged
sharwell merged 2 commits intodotnet:masterfrom May 25, 2018
Merged
Conversation
Contributor
|
This is not hard to review :( it would be nice to at least get a response in 4 months. |
CyrusNajmabadi
approved these changes
Mar 26, 2018
Contributor
|
@dotnet-bot retest this please |
1 similar comment
Contributor
|
@dotnet-bot retest this please |
sharwell
approved these changes
May 24, 2018
Contributor
|
Approved to merge for 15.8.preview3 when test green |
Contributor
|
Sorry for my previous comment, I didn't mean it in a negative way! It's easy to miss or forget PRs if there wasn't any activity on them. Hopefully that will continue to get better in the future. I also understand why this wouldn't be very high on the priority list. |
Contributor
|
retest windows_release_vs-integration_prtest please |
Contributor
|
retest windows_debug_vs-integration_prtest please |
Contributor
|
retest windows_release_unit32_prtest please |
Contributor
Author
|
@Neme12 thanks (: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using more efficient way to get number of instance constructors.
Ask Mode template not completed
Customer scenario
What does the customer do to get into this situation, and why do we think this
is common enough to address for this release. (Granted, sometimes this will be
obvious "Open project, VS crashes" but in general, I need to understand how
common a scenario is)
Bugs this fixes
(either VSO or GitHub links)
Workarounds, if any
Also, why we think they are insufficient for RC vs. RC2, RC3, or RTW
Risk
This is generally a measure our how central the affected code is to adjacent
scenarios and thus how likely your fix is to destabilize a broader area of code
Performance impact
(with a brief justification for that assessment (e.g. "Low perf impact because no extra allocations/no complexity changes" vs. "Low")
Is this a regression from a previous update?
Root cause analysis
How did we miss it? What tests are we adding to guard against it in the future?
How was the bug found?
(E.g. customer reported it vs. ad hoc testing)
Test documentation updated?
If this is a new non-compiler feature or a significant improvement to an existing feature, update https://github.com/dotnet/roslyn/wiki/Manual-Testing once you know which release it is targeting.