Remove syntax of "in" parameters#22182
Merged
OmarTawfik merged 1 commit intodotnet:features/readonly-reffrom Sep 19, 2017
OmarTawfik:remove-in-parameters
Merged
Remove syntax of "in" parameters#22182OmarTawfik merged 1 commit intodotnet:features/readonly-reffrom OmarTawfik:remove-in-parameters
OmarTawfik merged 1 commit intodotnet:features/readonly-reffrom
OmarTawfik:remove-in-parameters
Conversation
Member
what happened to in parameters? |
Contributor
Author
|
@alrz this branch supported initially two ways of defining read only reference parameters, either |
Contributor
Author
|
cc @dotnet/roslyn-compiler @dotnet/roslyn-ide @VSadov |
Member
|
@OmarTawfik I see that. I mean, why? Is it discarded or pushed to another version? |
Contributor
Author
|
@alrz yes, it was dropped in favor of |
jasonmalinowski
approved these changes
Sep 19, 2017
Member
jasonmalinowski
left a comment
There was a problem hiding this comment.
Is a new change needed to ensure "ref readonly" is suggested correctly in the keyword recommenders?
Contributor
Author
|
@jasonmalinowski it was already implemented in an earlier PR. |
jaredpar
approved these changes
Sep 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.