Add missing editor configuration properties#22143
Merged
sharwell merged 3 commits intodotnet:masterfrom Jun 9, 2019
Merged
Conversation
Contributor
Author
|
@dotnet/roslyn-infrastructure This doesn't actually change the settings we're using, it merely sets them in .editorconfig instead of relying on individual settings on the contributors' machines. |
Contributor
Author
|
@kuhlenh Can you review this against the PR you've been working on? |
|
@sharwell will get to this soon. FYI we're axing some of those formatting rules because they aren't changed from default values |
Contributor
|
Oooh, tell me more. Which ones are getting the ax? :) |
0d7bc4d to
81966c1
Compare
Contributor
Author
|
@dotnet/roslyn-infrastructure This needs to be merged. Reviewers are commenting on deviations in code style for formatting options that are not defined by the project settings, which by definition means that the style choice is at the discretion of individual developers. |
jasonmalinowski
approved these changes
Oct 26, 2018
81966c1 to
d5ba118
Compare
d5ba118 to
37489d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some differences between my local settings and the code in the repository, only to find that the .editorconfig file we're using was incomplete. I added the missing code style properties for uniform behavior in cases where users have customized settings in Tools → Options...