Removed text truncation logic from Introduce Variable codeaction#21374
Merged
jinujoseph merged 1 commit intodotnet:masterfrom Jun 9, 2018
Merged
Removed text truncation logic from Introduce Variable codeaction#21374jinujoseph merged 1 commit intodotnet:masterfrom
jinujoseph merged 1 commit intodotnet:masterfrom
Conversation
DustinCampbell
approved these changes
Sep 8, 2017
Member
DustinCampbell
left a comment
There was a problem hiding this comment.
Assuming the UI is tested to ensure that everything looks OK, I think this is fine.
Contributor
|
Interesting. THe link mentions that they also remove newlines and whatnot. So we could get rid of our ConvertToSingleLine helper in several cases. |
sharwell
approved these changes
May 24, 2018
Contributor
sharwell
left a comment
There was a problem hiding this comment.
LGTM as long as someone tries it locally with a long expression spanning multiple lines. Ideally that person adds a screenshot here of the before/after so it's clear what the change did.
Contributor
|
@JieCarolHu to validate the change |
Contributor
|
Verified it works as expected
|
JieCarolHu
approved these changes
Jun 8, 2018
Contributor
|
@jinujoseph Could you approve this merge? Thanks |
Contributor
|
Approved to merge for 15.8.Preview4 |
Contributor
|
thanks zaytsev-victor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5258