Add an async test case for a try/finally with an uncaught exception#20154
Merged
agocke merged 2 commits intodotnet:masterfrom Jun 12, 2018
Merged
Add an async test case for a try/finally with an uncaught exception#20154agocke merged 2 commits intodotnet:masterfrom
agocke merged 2 commits intodotnet:masterfrom
Conversation
Contributor
Author
|
I believe the integration test failure is #20157 |
Member
|
Tagging @dotnet/roslyn-compiler for review. |
gafter
approved these changes
Apr 20, 2018
Member
|
@drcjt would you be able to rebase your code off of master? Sorry we lost track of this PR and it looks like some merge conflicts have made their way in the mean time. |
Contributor
Author
|
@jaredpar no problem - rebased as requested. |
333fred
approved these changes
May 3, 2018
Member
|
@drcjt thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an extra async test case covering finally block entered from exceptional control flow rather than ordinary control flow.
Fixes #19905